Re: Re: [COMMITTERS] pgsql: Derived files that are shipped in the distribution used to be

On Wed, Sep 2, 2009 at 21:05, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> On ons, 2009-09-02 at 19:24 +0200, Magnus Hagander wrote:
>>> -kwlookup.c: % : ../../../backend/parser/%
>>> +kwlookup.c: % : $(top_srcdir)/src/backend/parser/%
>>> rm -f $@ && $(LN_S) $< .
>
>> I think you can revert this if it helps you, although it's not clear to
>> me why it would make a difference one way or the other.
>
> It looks to me like Magnus' git tool has gotten the direction of the
> change backwards --- $(top_srcdir) was the old coding, which was like
> every other place that is symlinking something, and the new ../../ bit
> is gratuitously unlike the rest.  I imagine the point is that the MSVC
> scripts only know how to deal with the $(top_srcdir) form.

Um, right, that's the patch that fixes the problem, not that causes it :-) S'ry.

And yes, that's what happened.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/