Re: What has happened to pgxs?

From: Thomas Hallgren <thhal(at)mailblocks(dot)com>
To: Michael Paesold <mpaesold(at)gmx(dot)at>
Cc: pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Subject: Re: What has happened to pgxs?
Date: 2005-09-23 06:40:13
Message-ID: thhal-00DsPBG9j8bQ9p3F40SRmxyzHRvYNly@mailblocks.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Sorry, that conclusion was wrong. What happens is:
1. I change the prefix in Makefile.global to say,
C:/Progra~1/PostgreSQL/8.1-beta2 (this is the default for the installer).
2. I compile.

That triggers the append of 'postgresql' on all directories since my
install location *does not* contain the word 'postgres' nor 'pgsql'.

Regards,
Thomas Hallgren

Thomas Hallgren wrote:
> There's another issue with the Makefile.global.in that I feel should be
> addressed here. The file contains a lot of entries like:
>
> ifeq "$(findstring pgsql, $(pkgincludedir))" ""
> ifeq "$(findstring postgres, $(pkgincludedir))" ""
> override pkgincludedir := $(pkgincludedir)/postgresql
> endif
> endif
>
> Guess what happens if the install-location in itself contains the string
> postgres?
> A more correct way of doing it is probably to check if the directory in
> question *ends with* pgsql or postgres rather then if it contains it.
>
> Regards,
> Thomas Hallgren
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
> choose an index scan if your joining column's datatypes do not
> match
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Page 2005-09-23 07:13:10 Re: pgxs and pginstaller
Previous Message Thomas Hallgren 2005-09-23 06:20:19 Re: What has happened to pgxs?