From: | Manuel Sugawara <masm(at)fciencias(dot)unam(dot)mx> |
---|---|
To: | Alvaro Herrera <alvherre(at)atentus(dot)com> |
Cc: | pgman(at)candle(dot)pha(dot)pa(dot)us, t-ishii(at)sra(dot)co(dot)jp, peter_e(at)gmx(dot)net, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: regexp character class locale awareness patch |
Date: | 2002-04-18 17:11:20 |
Message-ID: | m3n0w1gcef.fsf@dep4.fciencias.unam.mx |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)atentus(dot)com> writes:
> En 17 Apr 2002 22:53:32 -0600
> Manuel Sugawara <masm(at)fciencias(dot)unam(dot)mx> escribió:
>
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> >
> > > Tatsuo Ishii wrote:
> > > > > I miss that case :-(. Here is the pached patch.
> > > > >
> > > > > Regards,
> > > > > Manuel.
> > > >
> > > > I also suggest that cclass_init() is called only if the locale is not
> > > > "C".
> > >
> > > OK, patch on hold while this is addressed.
> >
> > Here is a patch which addresses Tatsuo's concerns (it does return an
> > static struct instead of constructing it).
>
> Is there a reason to use "" instead of NULL in the "multis" member of
> that static struct?
Yes, read the code.
Regards,
Manuel.
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2002-04-18 20:20:36 | Names of view select rules |
Previous Message | Tom Lane | 2002-04-18 17:00:37 | Re: new food for the contrib/ directory |