Re: regexp character class locale awareness patch

From: Alvaro Herrera <alvherre(at)atentus(dot)com>
To: Manuel Sugawara <masm(at)fciencias(dot)unam(dot)mx>
Cc: pgman(at)candle(dot)pha(dot)pa(dot)us, t-ishii(at)sra(dot)co(dot)jp, peter_e(at)gmx(dot)net, pgsql-hackers(at)postgresql(dot)org
Subject: Re: regexp character class locale awareness patch
Date: 2002-04-18 16:05:35
Message-ID: 20020418120535.5524dff5.alvherre@atentus.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

En 17 Apr 2002 22:53:32 -0600
Manuel Sugawara <masm(at)fciencias(dot)unam(dot)mx> escribió:

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>
> > Tatsuo Ishii wrote:
> > > > I miss that case :-(. Here is the pached patch.
> > > >
> > > > Regards,
> > > > Manuel.
> > >
> > > I also suggest that cclass_init() is called only if the locale is not
> > > "C".
> >
> > OK, patch on hold while this is addressed.
>
> Here is a patch which addresses Tatsuo's concerns (it does return an
> static struct instead of constructing it).

Is there a reason to use "" instead of NULL in the "multis" member of
that static struct?

--
Alvaro Herrera (<alvherre[a]atentus.com>)
"La virtud es el justo medio entre dos defectos" (Aristoteles)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dav Coleman 2002-04-18 16:07:09 Re: [SQL] SQL Query Optimization
Previous Message Tom Lane 2002-04-18 16:01:50 Re: new food for the contrib/ directory