Re: [HACKERS] Gen_fmgrtab.sh fails with LANG=et_EE

From: "Marko Kreen" <markokr(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Gen_fmgrtab.sh fails with LANG=et_EE
Date: 2006-09-05 20:37:29
Message-ID: e51f66da0609051337x6abce533j3426deed5e4c7c5f@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On 9/5/06, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > Well, the line of code is
> > cpp_define=`echo $OIDSFILE | tr abcdefghijklmnopqrstuvwxyz ABCDEFGHIJKLMNOPQRSTUVWXYZ | sed -e 's/[^A-Z]/_/g'`
> > so it ought to be pretty obvious what the correct solution for the
> > problem "character ranges are locale-dependent" is.
>
> Doh. Patched that way.
>
> Curiously, I couldn't replicate the failure on Fedora 5 --- Marko's
> platform must have different locale behavior for et_EE.

Did you add it to locale-gen config and ran it?

Btw, I removed all the pipeline in my patch, because I felt
such messy pipeline for such a tiny thing is ugly. Especially
as the filename wont change that much. Thus I though it would
be cleaner to just put the symbol together with filename definition.

--
marko

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2006-09-05 20:55:12 Re: Win32 hard crash problem
Previous Message Tom Lane 2006-09-05 20:35:49 Re: Ding-dong, contrib is dead ...

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-09-05 21:29:49 Re: Open items for 8.2
Previous Message Joachim Wieland 2006-09-05 20:10:36 Re: Open items for 8.2