Re: --enable-xml instead of --with-libxml?

From: "Nikolay Samokhvalov" <nikolay(at)samokhvalov(dot)com>
To: "Bruce Momjian" <bruce(at)momjian(dot)us>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: --enable-xml instead of --with-libxml?
Date: 2007-04-04 13:05:33
Message-ID: e431ff4c0704040605o7398c3dbh3226b32788d4b9de@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On 3/27/07, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
>
> Where are we on this? Peter thought the consistency makes sense, but if
> we can provide functionality that doesn't require libxml, why not
> do it?

I'm still for --enable-xml and putting _everything_ XML-related under this
option. My main points are:
- we cannot guarantee that existing libxml2-free functions will not require
them in the future (because libxml2 contains useful routines);
- libxml2-free functions (e.g. Peter's XML mapping functions,
http://momjian.us/main/writings/pgsql/sgml/functions-xml.html#FUNCTIONS-XML-MAPPING)
produce XML values, but we cannot use XPath function for them unless we have
libxml2;
- people will make errors, trying to understand what needs libxml2, and
what doesn't -- approach "all or nothing" is simple and straightforward;

Well, it seems that I have no more arguments :-) If there is no objections,
I'll send the patch tonight.
If I am wrong and it's better to leave libxml2-free capabilities, then IMHO
we need to reflect it explicitly in the docs, what requires libxml2, and
what doesn't

--
Best regards,
Nikolay

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message NikhilS 2007-04-04 13:19:56 Re: Auto Partitioning
Previous Message Andrew Dunstan 2007-04-04 13:05:15 Re: IDENTITY/GENERATED v36 Re: Final version of IDENTITY/GENERATED patch

Browse pgsql-patches by date

  From Date Subject
Next Message NikhilS 2007-04-04 13:19:56 Re: Auto Partitioning
Previous Message Andrew Dunstan 2007-04-04 13:05:15 Re: IDENTITY/GENERATED v36 Re: Final version of IDENTITY/GENERATED patch