Re: IDENTITY/GENERATED v36 Re: Final version of IDENTITY/GENERATED patch

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Zoltan Boszormenyi <zb(at)cybertec(dot)at>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: IDENTITY/GENERATED v36 Re: Final version of IDENTITY/GENERATED patch
Date: 2007-04-04 13:05:15
Message-ID: 4613A28B.2040808@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Zoltan Boszormenyi wrote:
> Tom Lane írta:
>
>>> - unique index checks are done in two steps
>>> to avoid inflating the sequence if a unique index check
>>> is failed that doesn't reference the IDENTITY column
>>>
>>
>> This is just not acceptable --- there is nothing in the standard that
>> requires such behavior,
>
> But also there is nothing that would say not to do it. :-)
> And this way, there is be nothing that would separate
> IDENTITY from regular SERIALs only the slightly
> later value generation. The behaviour I proposed
> would be a big usability plus over the standard
> with less possible skipped values.
>
>> and I dislike the wide-ranging kluges you
>> introduced to support it.
>
> Can you see any other way to avoid skipping sequence values
> as much as possible?

This doesn't strike me as a sensible design goal. Why not just live with
skipped values?

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikolay Samokhvalov 2007-04-04 13:05:33 Re: --enable-xml instead of --with-libxml?
Previous Message Peter Eisentraut 2007-04-04 13:04:15 Re: xpath_array with namespaces support

Browse pgsql-patches by date

  From Date Subject
Next Message Nikolay Samokhvalov 2007-04-04 13:05:33 Re: --enable-xml instead of --with-libxml?
Previous Message Peter Eisentraut 2007-04-04 13:04:15 Re: xpath_array with namespaces support