Re: boolean in C

On 16 Jul 2009, at 15:17, Tom Lane wrote:

> Grzegorz Jaskiewicz <gj(at)pointblue(dot)com(dot)pl> writes:
>
> That's hardly going to improve readability for anyone. Also, it will
> flat out not work for the catalog struct declarations. When we say
> "bool relhasindex;" the compiler had better think that that's a
> one-byte field.

Sure, but I would certainly hope, there's not too many places where
you actually convert it from disc representation, to internal and vice
versa.

>
>> And it is pretty annoying, when your product also has its own BOOLean
>> defined...
>
> IOW you're not using stdbool either?

Well, saying that I don't is quite an overstatement. It was decided
long before I started working for that customer, and is full of
problems like that. But still,
it would be nice for postgresql to at least not cause problems like
that. Having said that, I will probably fix it on customer's side, but
I wanted to see if you guys will be happy with patch that changes that
in postgresql.

thanks .