| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Grzegorz Jaskiewicz <gj(at)pointblue(dot)com(dot)pl> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Bernd Helmle <mailings(at)oopsware(dot)de> |
| Subject: | Re: boolean in C |
| Date: | 2009-07-16 15:42:56 |
| Message-ID: | 10356.1247758976@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Grzegorz Jaskiewicz <gj(at)pointblue(dot)com(dot)pl> writes:
> On 16 Jul 2009, at 15:17, Tom Lane wrote:
>> That's hardly going to improve readability for anyone. Also, it will
>> flat out not work for the catalog struct declarations. When we say
>> "bool relhasindex;" the compiler had better think that that's a
>> one-byte field.
> Sure, but I would certainly hope, there's not too many places where
> you actually convert it from disc representation, to internal and vice
> versa.
We don't "convert" --- it's expected to be the same representation.
As for not too many of them, I think grepping for references to bool
catalog fields will show you differently ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bernd Helmle | 2009-07-16 15:46:38 | Re: boolean in C |
| Previous Message | Heikki Linnakangas | 2009-07-16 15:41:37 | Re: Synch Rep for CommitFest 2009-07 |