Re: unlogged tables vs. GIST

Hi Heikki,

On Mon, Feb 11, 2013 at 7:28 PM, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com
> wrote:

> On 11.02.2013 08:44, Jeevan Chalke wrote:
>
>> Hi,
>>
>> Any review comments on this ?
>>
>
> Sorry for the delay.
>
> I did some minor cleanup on this. I added code to pg_resetxlog and
> pg_controldata to reset / display the current unlogged LSN value. I moved
> the static counter, for temporary relations, back to gistutil.c, so that
> the function in xlog.c only deals with unlogged relations. It's debatable
> if that's better, but IMHO it is. Also, the unloggedLSN counter is now
> reset to 1 at crash recovery. There's no fundamental reason it needs to be
> reset, rather than just continue from the last shutdowned value like
> nothing happened, but it seems cleaner that way.
>
> I'm happy with this now, but please take one more look before I commit
> this.
>

This morning I had a look over this. But it seems that you have already
committed it.

Changes are fine and even better.
No issues with my unit testing too.

Thanks for the commit.

>
> - Heikki
>

--
Jeevan B Chalke
Senior Software Engineer, R&D
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91 20 30589500

Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb

This e-mail message (and any attachment) is intended for the use of the
individual or entity to whom it is addressed. This message contains
information from EnterpriseDB Corporation that may be privileged,
confidential, or exempt from disclosure under applicable law. If you are
not the intended recipient or authorized to receive this for the intended
recipient, any use, dissemination, distribution, retention, archiving, or
copying of this communication is strictly prohibited. If you have received
this e-mail in error, please notify the sender immediately by reply e-mail
and delete this message.