Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration?

From: David Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>
To: pgsql-docs(at)postgresql(dot)org
Subject: Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration?
Date: 2014-06-08 14:49:19
Message-ID: CAKFQuwa5d3EUBGwYN1mA6FKO1K7kO+Wci8yM57QNHdEGQ9TJ9g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

​Re-sending to hopefully avoid admin moderation rule.​ Fixing top-post as
well.

On Wed, May 21, 2014 at 4:37 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
>> David G Johnston <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
>> > Section 18.1.3 is named "18.1.3. Other Ways to Set Parameters" yet does
>> not
>> > reference the ability to use "set_config(...)" to make changes to
>> > configuration parameters.
>>
>> Hm, yeah, seems like an oversight.
>>
>> Another thing I've never been terribly happy about is that pg_settings is
>> mentioned only in the next sub-section. Could we merge that sub-section
>> with 18.1.3?
>>
>> regards, tom lane
>>
>
> ​​

> I am presuming that posting a doc-only patch here instead of -hackers is
> acceptable.
>
> So I finally decided to setup a development environment and generate
> actual patches. I have few in mind but I thought that these two changes
> might be quick to implement. I thought wrong - mostly due to my desire to
> improve things and not just "add and merge" some content.
>
> I focused my effort on 18.1.1 to 18.1.4 though the actual coverage of
> sections 2-4 has changed considerably. I decided not to minimize
> white-space changes in that region since because of the re-organization git
> was unable, especially in a couple of instances, to match up before and
> after anyway. The file itself does not have a consistent format and so I
> just applied 2-space indentations at each level. I plan to go back and do
> polishing but I first want to make sure that the end-user product is
> acceptable.
>
> I've only hit this one file for the moment but figure on reviewing all of
> the relevant cross-references for tweaks and consistency. I already did so
> in passing and would not expect anything as invasive as what I am proposing
> here - so if others feel these changes have merit I will plan on taking any
> ideas and put forth a v2 patch that will hopefully be ready-to-commit.
>
> Thank you in advance for any attention and education you can provide.
>
> David J.
>

Attachment Content-Type Size
config_sgml_18_1_1-4_v1.diff text/plain 19.2 KB

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Tomonari Katsumata 2014-06-12 04:43:36 disabling log_rotation_age feature.
Previous Message David Johnston 2014-06-06 00:56:35 Re: Some qualms with the current description of RegExp s,n,w modes.

Browse pgsql-hackers by date

  From Date Subject
Next Message David G Johnston 2014-06-08 14:51:14 Re: configure does not check for bison or flex
Previous Message Eric L 2014-06-08 14:40:21 configure does not check for bison or flex