| From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Sergey Muraviov <sergey(dot)k(dot)muraviov(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu> |
| Subject: | Re: wrapping in extended mode doesn't work well with default pager |
| Date: | 2014-05-12 11:35:43 |
| Message-ID: | CAE2gYzyMrS7XarOKXke-Shuahs4FP2Yd5=d2wcHr_=iuG_2w9w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
> Hello
>
> I am checking feature
> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=6513633b94173fc1d9e2b213c43f9422ddbf5faa
>
> It works perfect with pager "less", but it works badly with default "more"
>
> see attached screenshots, pls
>
> It is expected behave?
I do not think so. It looks broken with or without any pager when
border != 2. Your less configuration might be hiding the problem from you.
I think it is because of miscalculation of the width used by
the separators. Increasing this variable for border = 0 and 1 fixed
the problem, but it might not be the right fix. The patch without
regression test changes attached.
While looking at it, I found another problem. It seems to me, a minus sign
is missing after -[RECORD ] when border = 1.
| Attachment | Content-Type | Size |
|---|---|---|
| psql-wrapped-expanded-fix.patch | application/octet-stream | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2014-05-12 11:40:01 | Re: Archive recovery won't be completed on some situation. |
| Previous Message | Fujii Masao | 2014-05-12 11:29:29 | Re: Archive recovery won't be completed on some situation. |