Re: [sepgsql 2/3] Add db_schema:search permission checks

From: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PgHacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [sepgsql 2/3] Add db_schema:search permission checks
Date: 2013-04-04 12:26:13
Message-ID: CADyhKSVo5dyTSdPDRC8k5doh2rwSYBUPMU6wek017BS9J4ryGw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2013/4/3 Robert Haas <robertmhaas(at)gmail(dot)com>:
> On Tue, Apr 2, 2013 at 2:22 PM, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
>> OK, please check the attached ones.
>
> Thanks. I reviewed the schema-search patch and I think it looks
> reasonable, but shouldn't we be calling the event OAT_NAMESPACE_SEARCH
> rather than OAT_SCHEMA_SEARCH? And, similarly,
> ObjectAccessNamespaceSearch and InvokeNamespaceSearchHook? I think
> this terminology could be confusing to backend hackers who are used to
> seeing the term "namespace" internally when referring to schemas.
>
OK, I follow the manner of the terminology as we usually call it.
The attached patch just replaced things you suggested.

I'll also rebase the function-exec permission stuff later.

Thanks,
--
KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>

Attachment Content-Type Size
sepgsql-v9.3-schema-search-permission.v4.patch application/octet-stream 45.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2013-04-04 12:30:40 Re: corrupt pages detected by enabling checksums
Previous Message Dimitri Fontaine 2013-04-04 12:16:08 Re: CREATE EXTENSION BLOCKS