Re: [PATCH] Fix PostgreSQL server build and install problems under MSYS2

From: Guram Duka <guram(dot)duka(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Fix PostgreSQL server build and install problems under MSYS2
Date: 2019-11-12 06:03:37
Message-ID: CABVxKcycNie3-zN1eY560esj9BCVtQTsdDHjMhRgZg3WzuZZLw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thank you for your comments.

1. The #if ... defined(__ cplusplus) is necessary for the successful
compilation of C++ llvmjit code that uses C headers.
2. #if defined(HAVE_GSS_API_H) && !defined(GSS_DLLIMP) is necessary for the
successful link libgss.a provided by MSYS2.
3. Remember that you need to run autoreconf before running configure.
4. Found and fixed a small bug in the patch. Build in environment CentOS
7.7.1908 works. Build in environment MSYS2 gcc 9.2.0 works. Build in
environment Visual Studio Community 2019 works.

The second version of the patch attached.
Waiting for your comments.

--
Best regards.
Guram Duka.

Attachment Content-Type Size
postgresql-11.5-msys2-v2.patch application/octet-stream 16.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2019-11-12 06:27:35 Re: [BUG FIX] Uninitialized var fargtypes used.
Previous Message Amit Kapila 2019-11-12 05:49:11 Re: Ordering of header file inclusion