Re: [BUG FIX] Uninitialized var fargtypes used.

At Tue, 12 Nov 2019 12:31:41 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in
> On Mon, Nov 11, 2019 at 06:28:47PM +0000, Ranier Vilela wrote:
> > Can anyone check this bug fix?
> >
> > +++ event_trigger.c Mon Nov 11 13:52:35 2019
> > @@ -171,7 +171,7 @@
> > HeapTuple tuple;
> > Oid funcoid;
> > Oid funcrettype;
> > - Oid fargtypes[1]; /* dummy */
> > + Oid fargtypes[1] = {InvalidOid, InvalidOid}; /* dummy */
> > Oid evtowner = GetUserId();
>
> Yeah, it would be better to fix this initialization.

Agreed, but compiler should complain since the initializer is too
long. And I found at least five other instances of the same. Or there
might be similar cases.

find . -type f -exec egrep --color -nH --null -e 'LookupFuncName ?\(.*, ?0,' \{\} +
./pl/tcl/pltcl.c619: procOid = LookupFuncName(namelist, 0, fargtypes, false);
./backend/commands/trigger.c693: funcoid = LookupFuncName(stmt->funcname, 0, fargtypes, false);
./backend/commands/proclang.c108: handlerOid = LookupFuncName(funcname, 0, funcargtypes, true);
./backend/commands/proclang.c266: handlerOid = LookupFuncName(stmt->plhandler, 0, funcargtypes, false);
./backend/commands/event_trigger.c240: funcoid = LookupFuncName(stmt->funcname, 0, fargtypes, false);
./backend/commands/foreigncmds.c484: handlerOid = LookupFuncName((List *) handler->arg, 0, funcargtypes, false);

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center