| From: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Setting visibility map in VACUUM's second phase |
| Date: | 2013-01-24 09:28:37 |
| Message-ID: | CABOikdMrfTdP35cs_gZ-GfLxH2+qS9JJoWf7=PQo7pPBBqFeNw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Jeff,
On Thu, Jan 24, 2013 at 2:41 PM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
>
> lazy_vacuum_page now pins and unpins the vmbuffer for each page it marks
> all-visible, which seems like a lot of needless traffic since the next
> vmbuffer is likely to be the same as the previous one.
>
Good idea. Even though the cost of pinning/unpinning may not be high
with respect to the vacuum cost itself, but it seems to be a good idea
because we already do that at other places. Do you have any other
review comments on the patch or I'll fix this and send an updated
patch soon.
Thanks,
Pavan
--
Pavan Deolasee
http://www.linkedin.com/in/pavandeolasee
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xi Wang | 2013-01-24 09:33:01 | [PATCH 0/3] Work around icc miscompilation |
| Previous Message | Pavan Deolasee | 2013-01-24 09:13:39 | Re: CF3+4 (was Re: Parallel query execution) |