Re: pgsql: Allow units to be specified in relation option setting value.

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Fujii Masao <fujii(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Allow units to be specified in relation option setting value.
Date: 2014-08-28 14:10:09
Message-ID: CAB7nPqTpdGLqLTxuGhBC2GabGNiFRAtLjFbxu=aGy1rX_DgwUg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Aug 28, 2014 at 10:51 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> Because of how reloptions is registered in pg_class:
The patch attached fixes pg_upgrade by putting quotes when generating
reloptions and it passes check-world. I imagine that having quotes by
default in the value of reloptions in pg_class is the price to pay for
supporting units. If this is not considered as a correct approach,
then reverting the patch would be wiser I guess.
Regards,
--
Michael

Attachment Content-Type Size
20140828_relopt_unit_fix.patch text/x-diff 11.8 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-08-28 14:14:53 Re: [COMMITTERS] pgsql: Allow units to be specified in relation option setting value.
Previous Message Michael Paquier 2014-08-28 13:51:54 Re: pgsql: Allow units to be specified in relation option setting value.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-08-28 14:12:19 Re: re-reading SSL certificates during server reload
Previous Message Magnus Hagander 2014-08-28 14:07:42 Re: re-reading SSL certificates during server reload