Re: pgsql: Allow units to be specified in relation option setting value.

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Fujii Masao <fujii(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Allow units to be specified in relation option setting value.
Date: 2014-08-28 13:51:54
Message-ID: CAB7nPqSeVWnhk-TA-GJBDgea-1ZLT8WFYwSp_63ut2ia8W9wrQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Aug 28, 2014 at 9:28 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> Oh,, will check.

That's a problem with pg_dump not able to put quotes where for a
reloption units are used.
For example this table:
create table test (a int) with (autovacuum_vacuum_cost_delay = '80ms');
Results in the following dump:
CREATE TABLE test (
a integer
)
WITH (autovacuum_vacuum_cost_delay=80ms);

Because of how reloptions is registered in pg_class:
=# select relname,reloptions from pg_class where relname = 'test';
relname | reloptions
---------+-------------------------------------
test | {autovacuum_vacuum_cost_delay=80ms}
(1 row)
Regards,
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2014-08-28 14:10:09 Re: pgsql: Allow units to be specified in relation option setting value.
Previous Message Fujii Masao 2014-08-28 12:28:05 Re: pgsql: Allow units to be specified in relation option setting value.

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2014-08-28 13:53:40 Re: Specifying the unit in storage parameter
Previous Message David G Johnston 2014-08-28 13:41:31 Re: Why data of timestamptz does not store value of timezone passed to it?