From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Some messages of pg_rewind --debug not getting translated |
Date: | 2016-03-23 06:01:03 |
Message-ID: | CAB7nPqQ2tJvAV+XgCz5SV1Nwywy_jfmvAxVEw9GyFgPvAmMXNg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Mar 23, 2016 at 12:24 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Seems reasonable. For the last hunk in your patch, though, I would add
> a /* translator: */ comment explaining what each of the values is;
> otherwise it's just incomprehensible percent-sign-salad for the poor
> translator. Note that if the line is too long you have to use dirty
> tricks to avoid pgindent from messing it up (see 673b52753489 for
> example)
OK, done this way.
> I'm not sure if we should keep "blk" in the original or make it a
> complete word.
OK, a complete word makes more sense.
--
Michael
Attachment | Content-Type | Size |
---|---|---|
pg-rewind-debug-fix-v2.patch | binary/octet-stream | 2.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavan Deolasee | 2016-03-23 06:43:19 | pg_xlogdump fails to handle WAL file with multi-page XLP_FIRST_IS_CONTRECORD data |
Previous Message | Craig Ringer | 2016-03-23 05:44:57 | Re: 2PC support for pglogical |