Re: Some messages of pg_rewind --debug not getting translated

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Some messages of pg_rewind --debug not getting translated
Date: 2016-03-22 15:24:26
Message-ID: 20160322152426.GA446439@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Seems reasonable. For the last hunk in your patch, though, I would add
a /* translator: */ comment explaining what each of the values is;
otherwise it's just incomprehensible percent-sign-salad for the poor
translator. Note that if the line is too long you have to use dirty
tricks to avoid pgindent from messing it up (see 673b52753489 for
example)

I'm not sure if we should keep "blk" in the original or make it a
complete word.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2016-03-22 15:40:22 Re: [PATCH] we have added support for box type in SP-GiST index
Previous Message Andres Freund 2016-03-22 15:11:12 Re: Speed up Clog Access by increasing CLOG buffers