| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: errno clobbering in reorderbuffer |
| Date: | 2016-08-19 02:21:40 |
| Message-ID: | CA4EF398-5F34-407B-99C8-CF0DBAFE1E36@anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On August 18, 2016 7:21:03 PM PDT, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>Andres Freund wrote:
>> On 2016-08-18 19:06:02 -0300, Alvaro Herrera wrote:
>> > While researching a customer issue with BDR I noticed that one
>ereport()
>> > call happens after clobbering errno, leading to the wrong strerror
>being
>> > reported. This patch fixes it by saving before calling
>> > CloseTransientFile and restoring afterwards.
>> >
>> > I also threw in a missing errcode I noticed while looking for
>similar
>> > problems in the same file.
>> >
>> > This is to backpatch to 9.4.
>>
>> Makes sense - you're doing that or shall I?
>
>I am, if you don't mind.
Not at all, thanks.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | amul sul | 2016-08-19 04:53:43 | Re: Bug in to_timestamp(). |
| Previous Message | Alvaro Herrera | 2016-08-19 02:21:03 | Re: errno clobbering in reorderbuffer |