| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: errno clobbering in reorderbuffer |
| Date: | 2016-08-19 02:21:03 |
| Message-ID: | 20160819022103.GA985423@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund wrote:
> On 2016-08-18 19:06:02 -0300, Alvaro Herrera wrote:
> > While researching a customer issue with BDR I noticed that one ereport()
> > call happens after clobbering errno, leading to the wrong strerror being
> > reported. This patch fixes it by saving before calling
> > CloseTransientFile and restoring afterwards.
> >
> > I also threw in a missing errcode I noticed while looking for similar
> > problems in the same file.
> >
> > This is to backpatch to 9.4.
>
> Makes sense - you're doing that or shall I?
I am, if you don't mind.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-08-19 02:21:40 | Re: errno clobbering in reorderbuffer |
| Previous Message | Michael Paquier | 2016-08-19 02:18:10 | Re: Missing checks when malloc returns NULL... |