Re: [COMMITTERS] pgsql: Make fast promotion the default promotion mode.

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Make fast promotion the default promotion mode.
Date: 2013-05-01 16:10:30
Message-ID: CA+U5nMKgx-8+TgyaYDpJcb7_ddm=90-q31FrCZQXLtp16=G=JQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 1 May 2013 14:55, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Wed, May 1, 2013 at 9:20 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> On 1 May 2013 11:25, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>> On Wed, Apr 24, 2013 at 8:49 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>>>> Make fast promotion the default promotion mode.
>>>> Continue to allow a request for synchronous
>>>> checkpoints as a mechanism in case of problems.
>>>
>>> Is there clean way to request synchronous checkpoint at the standby promotion?
>>> I'm sure that we can do that by creating the file "promote" and
>>> sending the SIGUSR1
>>> signal to the postmaster. Or by using previous version of pg_ctl.
>>> These are not clean
>>> and would confuse users.
>>
>> I just removed the user interface at Heikki's request, so yes, I can
>> see its not ideal interface.
>>
>> My wish was to have a mechanism should we need it.
>>
>> A third option would be to not have any way at all.
>>
>> What is your preference?
>
> My preference is adding something like --full-checkpoint option into
> pg_ctl promote.
>
> As far as I understand Heikki's request correctly, he dislikes the
> approach reusing
> -m option in pg_ctl promote. That is, previous behavior of the promotion is not
> "smarter" than current one, but we have to have specified "-m smart" to choose
> the previous behavior of the promotion. ISTM that his this request makes sense.
>
> So I'd like to propose to add new option which would not confuse
> users, into pg_ctl
> promote.

Heikki said "...remove pg_ctl -m fast/smart option altogether. There
is no need to expose that to users."

So it is no longer exposed to users. If there are others that share
that opinion we may change this.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2013-05-01 16:20:25 Re: [COMMITTERS] pgsql: Add regression test for bug fixed by recent refactoring.
Previous Message Fujii Masao 2013-05-01 13:55:45 Re: [COMMITTERS] pgsql: Make fast promotion the default promotion mode.

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2013-05-01 16:14:46 Re: Re: [BUGS] BUG #8128: pg_dump (>= 9.1) failed while dumping a scheme named "old" from PostgreSQL 8.4
Previous Message Kevin Grittner 2013-05-01 16:06:28 Re: materialized view scannability in other DBs