Re: Re: [BUGS] BUG #8128: pg_dump (>= 9.1) failed while dumping a scheme named "old" from PostgreSQL 8.4

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Adrian(dot)Vondendriesch(at)credativ(dot)de, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [BUGS] BUG #8128: pg_dump (>= 9.1) failed while dumping a scheme named "old" from PostgreSQL 8.4
Date: 2013-05-01 16:14:46
Message-ID: 20130501161446.GA2127@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Wed, May 01, 2013 at 11:12:28AM -0400, Tom Lane wrote:
> David Fetter <david(at)fetter(dot)org> writes:
> > According to SQL:2003 and SQL:2008 (and the draft standard, if
> > that matters) in section 5.2 of Foundation, both NEW and OLD are
> > reserved words, so we're going to need to re-reserve them to
> > comply.
>
> We don't and won't.

Not so fast or so definite, if you please.

I've got a GSoC project in that implements things with both of these
keywords, and doubtless others will use other keywords either this
coming (9.4) cycle or in a later one.

If you want to have a discussion about the timing, that is a perfectly
reasonable discussion to have. Peremptorily saying, "don't and won't"
is not a great way to operate, however tempting it may be for you.

There is a case to be made, and I'm making it here, for pre-reserving
all the keywords and erroring out with "Feature not implemented" for
those not yet implemented. This would keep us, and more importantly
our user base, from wondering when the next random change to the SQL
language would affect them.

I'd suggest doing this over about 3 releases in the sense of warning
people at the appropriate juncture--I'm guessing at least CREATE,
ALTER, pg_dump(all) and pg_upgrade would be involved. Three releases
is just a suggestion intended to start a discussion.

> There are very many other keywords that are less reserved in
> Postgres than in the spec; this is a good thing.

How is it a good thing? Help me understand.

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Stefan Kaltenbrunner 2013-05-01 17:27:44 Re: Re: [BUGS] BUG #8128: pg_dump (>= 9.1) failed while dumping a scheme named "old" from PostgreSQL 8.4
Previous Message Stefan de Konink 2013-05-01 15:44:54 Re: [BUGS] BUG #8130: Hashjoin still gives issues

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-05-01 16:20:25 Re: [COMMITTERS] pgsql: Add regression test for bug fixed by recent refactoring.
Previous Message Simon Riggs 2013-05-01 16:10:30 Re: [COMMITTERS] pgsql: Make fast promotion the default promotion mode.