Re: Inaccuracy in VACUUM's tuple count estimates

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Inaccuracy in VACUUM's tuple count estimates
Date: 2014-06-09 14:14:32
Message-ID: CA+TgmobUbzYu9kmEzhYsBU--LaKkA1M32YEF4Yv2UzFsnzPZNg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 6, 2014 at 3:44 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> It did not use to blow this question off: back around 8.3 you got
> DELETE_IN_PROGRESS if the tuple had a delete pending. I think we need
> less laziness + fuzzy thinking here. Maybe we should have a separate
> HEAPTUPLE_INSERT_AND_DELETE_IN_PROGRESS result code? Is it *really*
> the case that callers other than VACUUM itself are okay with failing
> to make this distinction?

I think that would be a good idea for conceptual clarity if nothing
else. If callers are OK with it, then they can treat both of those
codes alike; but then at least there's clear evidence as to the
author's intent.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-06-09 14:18:40 Re: Supporting Windows SChannel as OpenSSL replacement
Previous Message jlrando 2014-06-09 14:10:03 Re: Hot standby 9.2.6 -> 9.2.6 PANIC: WAL contains references to invalid pages