From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | alter-table-1 isolation test spec contains a duplicate step name |
Date: | 2015-08-14 21:13:58 |
Message-ID: | CA+TgmoaDfaMEj5xXK0LzkMUsE27zPgju-QWK83-CSHWnJD5SYA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Commit f14a6bbedb79adce2298d0d4f5e2abe8563e0eca added an isolation
test, alter-table-1.spec, which reads in part:
session "s2"
setup { BEGIN; }
step "rx1" { SELECT * FROM b WHERE a_id = 1 LIMIT 1; }
step "wx" { INSERT INTO b VALUES (0); }
step "rx1" { SELECT * FROM b WHERE a_id = 3 LIMIT 3; }
step "c2" { COMMIT; }
The step name "rx1" is used twice, a condition the isolation tester
should probably reject as an error but currently doesn't. This
happens to work OK at the moment because we don't specify a list of
permutations, and except for that, the names aren't used for anything
that cares about whether they are duplicated. Nonetheless, this seems
like it should probably be changed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2015-08-14 21:18:22 | Re: alter-table-1 isolation test spec contains a duplicate step name |
Previous Message | Tom Lane | 2015-08-14 21:13:31 | Re: FDW question - how to identify columns to populate in response? |