Re: alter-table-1 isolation test spec contains a duplicate step name

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: alter-table-1 isolation test spec contains a duplicate step name
Date: 2015-08-14 21:18:22
Message-ID: 13410.1439587102@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Commit f14a6bbedb79adce2298d0d4f5e2abe8563e0eca added an isolation
> test, alter-table-1.spec, which reads in part:

> session "s2"
> setup { BEGIN; }
> step "rx1" { SELECT * FROM b WHERE a_id = 1 LIMIT 1; }
> step "wx" { INSERT INTO b VALUES (0); }
> step "rx1" { SELECT * FROM b WHERE a_id = 3 LIMIT 3; }
> step "c2" { COMMIT; }

> The step name "rx1" is used twice, a condition the isolation tester
> should probably reject as an error but currently doesn't.

+1 for throwing an error ... this is clearly a mistake.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dickson S. Guedes 2015-08-14 23:58:55 [RFC] allow 'semester' in functions EXTRACT, DATE_PART, TO_CHAR and so on.
Previous Message Robert Haas 2015-08-14 21:13:58 alter-table-1 isolation test spec contains a duplicate step name