Re: "page is not marked all-visible" warning in regression tests

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: "page is not marked all-visible" warning in regression tests
Date: 2012-06-07 16:23:58
Message-ID: CA+TgmoZ9hNFwVzWJOcEwoGbqEmAgFk4bnj86DBzRrGhy07Hvbw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 7, 2012 at 12:19 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> You could do a visibilitymap_pin outside, but I don't really see the point as
> the page is already locked. There might be some slight benefit in doing so in
> multi_insert but that would be more complicated. And of doubtful benefit.

Doesn't RelationGetBufferForTuple() already do exactly that?

>> Updated patch attached.
> Looks good.

Thanks for the review.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2012-06-07 16:27:11 Re: slow dropping of tables, DropRelFileNodeBuffers, tas
Previous Message Andres Freund 2012-06-07 16:23:52 Re: Ability to listen on two unix sockets