| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: "page is not marked all-visible" warning in regression tests |
| Date: | 2012-06-07 16:28:02 |
| Message-ID: | 201206071828.02799.andres@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thursday, June 07, 2012 06:23:58 PM Robert Haas wrote:
> On Thu, Jun 7, 2012 at 12:19 PM, Andres Freund <andres(at)2ndquadrant(dot)com>
wrote:
> > You could do a visibilitymap_pin outside, but I don't really see the
> > point as the page is already locked. There might be some slight benefit
> > in doing so in multi_insert but that would be more complicated. And of
> > doubtful benefit.
>
> Doesn't RelationGetBufferForTuple() already do exactly that?
Forget it, sorry. I mis(read|remembered) how multi_insert works and concluded
from that on how insert works...
Andres
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-06-07 16:34:01 | Re: slow dropping of tables, DropRelFileNodeBuffers, tas |
| Previous Message | Tom Lane | 2012-06-07 16:27:35 | Re: Avoiding adjacent checkpoint records |