Re: Speedup twophase transactions

From: Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Speedup twophase transactions
Date: 2016-04-08 18:57:59
Message-ID: BB39565C-82BC-4089-9268-CE306111C705@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> On 08 Apr 2016, at 21:42, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Tue, Jan 26, 2016 at 7:43 AM, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> wrote:
>> Hi,
>>
>> Thanks for reviews and commit!
>
> I apologize for being clueless here, but was this patch committed?
> It's still marked as "Needs Review" in the CommitFest application.

There was a patch to skip two phase file creation when there were no checkpoint
between PREPARE and COMMIT, and that patch was commited.
But that patch didn’t touch anything in replay, so replay speed of 2pc is significantly slower
than 2pc in normal mode. And that can cause constantly increasing replication lag for async
replication.
After that i’ve wrote new patch introducing same behaviour in replay and used the same
mail thread. Now Michael found a (heisen)bug in second patch, that i can’t reproduce.

Stas Kelvich
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Anastasia Lubennikova 2016-04-08 18:59:58 Re: pgsql: CREATE INDEX ... INCLUDING (column[, ...])
Previous Message Jesper Pedersen 2016-04-08 18:57:00 Re: Speedup twophase transactions