Re: [HACKERS] Issues with generate_series using integer boundaries

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Thom Brown <thom(at)linux(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PGSQL Mailing List <pgsql-general(at)postgresql(dot)org>
Subject: Re: [HACKERS] Issues with generate_series using integer boundaries
Date: 2011-06-17 03:44:55
Message-ID: BANLkTim8qzdYZdfHu6zpeY_Jqn8V58+DXA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Wed, Feb 9, 2011 at 4:50 AM, Thom Brown <thom(at)linux(dot)com> wrote:
> On 9 February 2011 02:11, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Tue, Feb 8, 2011 at 8:30 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>> Quite right, but the commitfest manager isn't meant to be a substitute for
>>> one. Bug fixes aren't subject to the same restrictions of feature changes.
>>
>> Another option would be to add this here:
>>
>> http://wiki.postgresql.org/wiki/PostgreSQL_9.1_Open_Items
>
> I've removed it from the commitfest because it really doesn't belong
> there, and I've added it to the open items list.

So, I finally got around to look at this, and I think there is a
simpler solution. When an overflow occurs while calculating the next
value, that just means that the value we're about to return is the
last one that should be generated. So we just need to frob the
context state so that the next call will decide we're done. There are
any of number of ways to do that; I just picked what looked like the
easiest one.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
generate-series-overflow.patch application/octet-stream 1.2 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Vikram A 2011-06-17 04:42:37 ncoding "Table Name" and "Filed Name"
Previous Message David Johnston 2011-06-16 23:53:30 Re: set returning function with variable argument - possible?

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-06-17 03:47:39 Re: pg_upgrade using appname to lock out other users
Previous Message Noah Misch 2011-06-17 03:17:52 Re: crash-safe visibility map, take five