Re: Complier warnings on mingw gcc 4.5.0

From: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, inoue(at)tpf(dot)co(dot)jp
Subject: Re: Complier warnings on mingw gcc 4.5.0
Date: 2010-11-09 02:27:26
Message-ID: AANLkTinvNUU3PHfLWiQOGVFAKbbABLA6e=xmJjcnpWpM@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 1, 2010 at 7:24 PM, Itagaki Takahiro
<itagaki(dot)takahiro(at)gmail(dot)com> wrote:
> 1. warning: '<symbol>' redeclared without dllimport attribute:
> previous dllimport ignored

I discussed with Hiroshi-san about the dllimport issue, and he pointed
out that __declspec(dllexport) and dllwrap cannot work well together.
So, the most suitable fix would be just removing __declspec (dllimport)
from PGDLLEXPORT for mingw.

diff --git a/src/include/port/win32.h b/src/include/port/win32.h
index 988c1c9..3417ab5 100644
*** a/src/include/port/win32.h
--- b/src/include/port/win32.h
***************
*** 61,67 ****
#ifdef _MSC_VER
#define PGDLLEXPORT __declspec (dllexport)
#else
! #define PGDLLEXPORT __declspec (dllimport)
#endif
#else /* not CYGWIN, not MSVC, not MingW */
#define PGDLLIMPORT
--- 61,67 ----
#ifdef _MSC_VER
#define PGDLLEXPORT __declspec (dllexport)
#else
! #define PGDLLEXPORT
#endif
#else /* not CYGWIN, not MSVC, not MingW */
#define PGDLLIMPORT

--
Itagaki Takahiro

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-11-09 02:46:28 Re: Removing pgsql_tmp files
Previous Message Alvaro Herrera 2010-11-09 01:56:38 Re: Removing pgsql_tmp files