Complier warnings on mingw gcc 4.5.0

From: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Complier warnings on mingw gcc 4.5.0
Date: 2010-11-01 10:24:30
Message-ID: AANLkTimFz3iexamZvCSq=T2Cdw0V-ViAhk66MkQ7jV9Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I compiled the source with mingw gcc 4.5.0, that has been released recently.
The compile was succeeded and worked well at least for simple queries,
but there were many warnings during the compile.
----
1. warning: '<symbol>' redeclared without dllimport attribute:
previous dllimport ignored
2. warning: unknown conversion type character 'm' in format
3. warning: unknown conversion type character 'l' in format
----

1 is easy to fix with the attached patch.
I wonder why mingw gcc < 4.5 can build codes without the fix...

For 2, we could remove __attribute__((format(printf))) on mingw, but
it also disables type checking for formatters. Are there better solutions?

I have not yet researched for 3, that might be most dangerous.

=# select version();
version
----------------------------------------------------------------------------------
PostgreSQL 9.0.1 on i686-pc-mingw32, compiled by GCC gcc.exe (GCC)
4.5.0, 32-bit
(1 row)

OS: Windows 7 64bit

diff --git a/src/include/port/win32.h b/src/include/port/win32.h
index 988c1c9..31c877f 100644
*** a/src/include/port/win32.h
--- b/src/include/port/win32.h
***************
*** 58,64 ****
#define PGDLLIMPORT __declspec (dllimport)
#endif

! #ifdef _MSC_VER
#define PGDLLEXPORT __declspec (dllexport)
#else
#define PGDLLEXPORT __declspec (dllimport)
--- 58,64 ----
#define PGDLLIMPORT __declspec (dllimport)
#endif

! #if defined(_MSC_VER) || __GNUC__ >= 4
#define PGDLLEXPORT __declspec (dllexport)
#else
#define PGDLLEXPORT __declspec (dllimport)

--
Itagaki Takahiro

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2010-11-01 10:32:49 Re: Tracking latest timeline in standby mode
Previous Message Fujii Masao 2010-11-01 09:34:18 Re: SR fails to send existing WAL file after off-line copy