| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: Invalid YAML output from EXPLAIN |
| Date: | 2010-06-09 16:52:55 |
| Message-ID: | AANLkTinZxNrOw0gZbkZem0o0cUpBemngtL-VDvYf3G9s@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Wed, Jun 9, 2010 at 12:25 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Wed, Jun 9, 2010 at 11:14 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Why not? Surely we can restrict EXPLAIN's set of key names to be safe.
>
>> It seems to me that it would be easy for a future patch to break this
>> by accident.
>
> Really? What likely key names would be in need of quoting? I can't
> imagine accepting a field name that contains punctuation or leading
> or trailing whitespace, for example.
It seemed to me, in particular, that someone might use a # symbol,
like "# of Iterations".
Maybe I'm being paranoid.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2010-06-09 16:57:50 | Re: Invalid YAML output from EXPLAIN |
| Previous Message | Dean Rasheed | 2010-06-09 16:38:53 | Re: Invalid YAML output from EXPLAIN |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David E. Wheeler | 2010-06-09 16:54:24 | Re: hstore ==> and deprecate => |
| Previous Message | Robert Haas | 2010-06-09 16:49:43 | Re: Idea for getting rid of VACUUM FREEZE on cold pages |