From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: Invalid YAML output from EXPLAIN |
Date: | 2010-06-09 16:38:53 |
Message-ID: | AANLkTikNPQk9pjxKIvvc1Rx0_qtpI5I0aWhXyHiX8mdU@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On 9 June 2010 17:25, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Wed, Jun 9, 2010 at 11:14 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Why not? Surely we can restrict EXPLAIN's set of key names to be safe.
>
>> It seems to me that it would be easy for a future patch to break this
>> by accident.
>
> Really? What likely key names would be in need of quoting? I can't
> imagine accepting a field name that contains punctuation or leading
> or trailing whitespace, for example.
>
And any of those things would break the XML output too.
I can't imagine that going unnoticed.
Dean
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-06-09 16:52:55 | Re: Invalid YAML output from EXPLAIN |
Previous Message | Tom Lane | 2010-06-09 16:25:18 | Re: Invalid YAML output from EXPLAIN |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-06-09 16:49:43 | Re: Idea for getting rid of VACUUM FREEZE on cold pages |
Previous Message | Tom Lane | 2010-06-09 16:30:24 | Re: hstore ==> and deprecate => |