| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Daniel Farina <daniel(at)heroku(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: XMin Hot Standby Feedback patch |
| Date: | 2011-02-15 17:15:44 |
| Message-ID: | AANLkTin96M5GbEyTkqdgeJcDWq2EhXc_HWNmFvhzax59@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 15, 2011 at 11:42 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> Patch attached, no docs yet, but the patch is clear.
>
> I'm looking to commit this in next 24 hours barring objections and/or
> test failures.
Looks pretty good to me, though I haven't tested it. I like some of
the safety valves you put in there, but I don't understand this part:
+ /*
+ * Feedback from standby should move us
forwards, but not too far.
+ * Avoid grabbing XidGenLock here in case of
waits, so use
+ * a heuristic instead.
+ */
What's XIDGenLock got to do with it?
On another disk, I think that those warning messages are a bad idea.
That could fill up someone's disk really quickly.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-02-15 17:18:27 | Re: extensions and psql |
| Previous Message | Andrew Dunstan | 2011-02-15 17:14:43 | Re: CommitFest 2011-01 as of 2011-02-04 |