| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Florian Pflug <fgp(at)phlo(dot)org>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Greg Smith <greg(at)2ndquadrant(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com> |
| Subject: | Re: Stefan's bug (was: max_standby_delay considered harmful) |
| Date: | 2010-05-17 11:33:05 |
| Message-ID: | AANLkTimdyy-1cOoNhYz-A-Ig_wNCl3F1bBWubY9X2aIe@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 17, 2010 at 7:14 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On Mon, 2010-05-17 at 06:55 -0400, Robert Haas wrote:
>
>> > I think we should review Masao's patch and ask him to make any changes
>> > we think are appropriate. There's no benefit to have multiple patch
>> > authors at one time.
>>
>> I did review his patch. It duplicates a few lines of logic and I
>> found a way to avoid that, so I proposed it. That seems totally
>> normal to me and I'm not sure what you're concerned about.
>
> I think we should concentrate efforts on just one patch: Masao's.
I understand that's your opinion, but you haven't explained why. My
approach is simpler and Fujii Masao has already endorsed it. I would
prefer that we focus on the technical issues here rather than who
wrote the patch. I believe that my approach is better because it
avoids duplicating code, which should reduce the chance of future
bugs, since someone might conceivably update one chunk of code but not
the other.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2010-05-17 11:38:28 | Re: Stefan's bug (was: max_standby_delay considered harmful) |
| Previous Message | Simon Riggs | 2010-05-17 11:14:59 | Re: Stefan's bug (was: max_standby_delay considered harmful) |