Re: PATCH: Minor notes in CLUSTER page

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Andy Lester <andy(at)petdance(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Minor notes in CLUSTER page
Date: 2010-05-11 16:08:04
Message-ID: AANLkTimQ3sgPbfzM99qGC2FuLgiwyJECTxror4F-YKtL@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 7, 2010 at 10:44 AM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Excerpts from Robert Haas's message of vie may 07 07:33:55 -0400 2010:
>> On Thu, May 6, 2010 at 3:29 PM, Andy Lester <andy(at)petdance(dot)com> wrote:
>> > I was looking for how to undo a CLUSTER call earlier today.  Nothing on
>> > the CLUSTER page told me how to do it, or pointed me to the ALTER TABLE
>> > page.  I figure a pointer to would help the next person in my situation.
>>
>> I've been annoyed by this too and so am in favor of adding a mention
>> in the documentation, but I think we should mention both the CLUSTER
>> and SET WITHOUT CLUSTER variants of ALTER TABLE, and since it's only
>> one sentence I think we should add it adjacent to the existing
>> sentence discussing remembering the index.  My proposed patch
>> attached; thoughts?
>
> dept. of minor nitpicks:
>
> change
> +   use <literal>CLUSTER</literal> or <literal>SET WITHOUT CLUSTER</literal>
>
> to
> +   use the <literal>CLUSTER ON</literal> or <literal>SET WITHOUT CLUSTER</literal>
>
> Other than that, +1 from me.

Committed with that change.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2010-05-11 16:36:05 Re: SHARE locks vs. DELETE in SERIALIZABLE mode (Was: Partitioning/inherited tables vs FKs)
Previous Message Tom Lane 2010-05-11 15:06:25 Re: Patch for PKST timezone