Re: PATCH: Minor notes in CLUSTER page

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andy Lester <andy(at)petdance(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Minor notes in CLUSTER page
Date: 2010-05-07 14:44:57
Message-ID: 1273243295-sup-3199@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Robert Haas's message of vie may 07 07:33:55 -0400 2010:
> On Thu, May 6, 2010 at 3:29 PM, Andy Lester <andy(at)petdance(dot)com> wrote:
> > I was looking for how to undo a CLUSTER call earlier today.  Nothing on
> > the CLUSTER page told me how to do it, or pointed me to the ALTER TABLE
> > page.  I figure a pointer to would help the next person in my situation.
>
> I've been annoyed by this too and so am in favor of adding a mention
> in the documentation, but I think we should mention both the CLUSTER
> and SET WITHOUT CLUSTER variants of ALTER TABLE, and since it's only
> one sentence I think we should add it adjacent to the existing
> sentence discussing remembering the index. My proposed patch
> attached; thoughts?

dept. of minor nitpicks:

change
+ use <literal>CLUSTER</literal> or <literal>SET WITHOUT CLUSTER</literal>

to
+ use the <literal>CLUSTER ON</literal> or <literal>SET WITHOUT CLUSTER</literal>

Other than that, +1 from me.

(Hmm, perhaps even say what each form is for right after mentioning it, instead
of mentioning both and then saying what both are for.)

--

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andy Lester 2010-05-07 14:48:29 Re: PATCH: Minor notes in CLUSTER page
Previous Message Andrew Dunstan 2010-05-07 14:38:47 Re: no universally correct setting for fsync