| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | David Fetter <david(at)fetter(dot)org> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Add SIGCHLD catch to psql |
| Date: | 2010-05-15 23:58:49 |
| Message-ID: | AANLkTimOoIzT01kv_N3cmwhKofu06xIvMBl1Xg0Zm4ZZ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 15, 2010 at 7:46 PM, David Fetter <david(at)fetter(dot)org> wrote:
>> > Anyway, this makes FETCH_COUNT alot more useful, and, in my view, the
>> > current behaviour of completely ignoring $PAGER exiting is a bug.
>>
>> Plesae add this to the next commit-fest:
>>
>> https://commitfest.postgresql.org/action/commitfest_view/inprogress
>>
>> Thanks.
>
> Wouldn't this count as a bug fix?
Possibly, but changes to signal handlers are pretty global and can
sometimes have surprising side effects. I'm all in favor of someone
reviewing the patch - any volunteers? One case to test might be
reading input from a file that contains \! escapes. More generally,
we need to consider every way that psql can get SIGCHLD and think
about whether this is the right behavior.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-05-16 00:09:23 | Re: [PATCH] Add SIGCHLD catch to psql |
| Previous Message | Michael Renner | 2010-05-15 23:53:49 | Unexpected page allocation behavior on insert-only tables |