| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | David Fetter <david(at)fetter(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Add SIGCHLD catch to psql |
| Date: | 2010-05-16 00:09:23 |
| Message-ID: | 20249.1273968563@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Sat, May 15, 2010 at 7:46 PM, David Fetter <david(at)fetter(dot)org> wrote:
>> Wouldn't this count as a bug fix?
> Possibly, but changes to signal handlers are pretty global and can
> sometimes have surprising side effects. I'm all in favor of someone
> reviewing the patch - any volunteers? One case to test might be
> reading input from a file that contains \! escapes. More generally,
> we need to consider every way that psql can get SIGCHLD and think
> about whether this is the right behavior.
I think this will introduce far more bugs than it fixes. A saner
approach, which would also help for other corner cases such as
out-of-disk-space, would be to check for write failures on the output
file and abandon the query if any occur.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-05-16 00:16:47 | Re: Unexpected page allocation behavior on insert-only tables |
| Previous Message | Robert Haas | 2010-05-15 23:58:49 | Re: [PATCH] Add SIGCHLD catch to psql |