| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Florian Pflug <fgp(at)phlo(dot)org>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Greg Smith <greg(at)2ndquadrant(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com> |
| Subject: | Re: Stefan's bug (was: max_standby_delay considered harmful) |
| Date: | 2010-05-19 05:47:35 |
| Message-ID: | AANLkTilc1BL42zR06S5pAr7kwlFilFlWpQu9aEai_m1a@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 19, 2010 at 12:59 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> In terms of removing the backup label file, can we simply have an
> additional boolean in the postmaster that indicates whether we've ever
> reached PM_RUN, and only consider removing the backup file if so?
Yes, but I prefer XLogCtl->SharedRecoveryInProgress, which is the almost
same indicator as the boolean you suggested. Thought?
>>>> ISTM that walreceiver might be invoked even after shutdown is requested.
>>>> We should prevent the postmaster from starting up walreceiver if
>>>> Shutdown > NoShutdown?
>>>
>>> Well, when we did the previous shutdown patch, we decided it was not
>>> right to kill walreceiver until all backends had exited, so it seems
>>> inconsistent to make the opposite decision here.
>>
>> Oh, right. How about allowing the postmaster only in PM_STARTUP,
>> PM_RECOVERY, PM_HOT_STANDBY or PM_WAIT_READONLY state to invoke
>> walreceiver? We can keep walreceiver alive until all read only
>> backends have gone, and prevent unexpected startup of walreceiver.
>
> Yes, that seems like something we should be checking, if we aren't already.
I'll do that.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2010-05-19 06:19:35 | Re: ecmascript 5 DATESTYLE |
| Previous Message | Pavel Stehule | 2010-05-19 05:28:23 | Re: ecmascript 5 DATESTYLE |