| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Florian Pflug <fgp(at)phlo(dot)org>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Greg Smith <greg(at)2ndquadrant(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com> |
| Subject: | Re: max_standby_delay considered harmful |
| Date: | 2010-05-13 03:07:29 |
| Message-ID: | AANLkTik_ay5lTJTEhAUqmEAREsKT7mEGxzmeJll3ERXw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 12, 2010 at 10:46 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Thu, May 13, 2010 at 4:55 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> I am wondering if we are not correctly handling the case where we get
>> a shutdown request while we are still in the PM_STARTUP state. It
>> looks like we might go ahead and switch to PM_RECOVERY and then
>> PM_RECOVERY_CONSISTENT without noticing the shutdown. There is some
>> logic to handle the shutdown when the startup process exits, but if
>> the startup process never exits it looks like we might get stuck.
>
> Right. I reported this problem and submitted the patch before.
> http://archives.postgresql.org/pgsql-hackers/2010-04/msg00592.php
Sorry we missed that.
> Stefan,
> Could you check whether the patch fixes the problem you encountered?
I think that would be a good thing to check (it'll confirm whether
this is the same bug), but I'm not convinced we should actually fix it
that way. Prior to 8.4, we handled a smart shutdown during recovery
at the conclusion of recovery, just prior to entering normal running.
I'm wondering if we shouldn't revert to that behavior in both 8.4 and
HEAD.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-05-13 03:10:06 | Re: recovery getting interrupted is not so unusual as it used to be |
| Previous Message | Fujii Masao | 2010-05-13 03:07:06 | Re: recovery getting interrupted is not so unusual as it used to be |