Re: Fwd: Pgadmin 1.12 rc1 editing bug

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pg(at)kuhnsteffen(dot)de, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Fwd: Pgadmin 1.12 rc1 editing bug
Date: 2010-09-06 19:11:17
Message-ID: AANLkTikDrPJV9CzRQKX_L09MzbcGWN+HE6KTT3Av00OB@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, Sep 6, 2010 at 5:44 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Le 06/09/2010 18:37, Dave Page a écrit :
>> On Mon, Sep 6, 2010 at 5:34 PM, Guillaume Lelarge
>> <guillaume(at)lelarge(dot)info> wrote:
>>> Le 06/09/2010 18:13, Dave Page a écrit :
>>>> On Mon, Sep 6, 2010 at 5:03 PM, Guillaume Lelarge
>>>> <guillaume(at)lelarge(dot)info> wrote:
>>>>> It's possible to disable the toolbar button, but we'll need to keep the
>>>>> menu item enabled so that the DEL key still triggers the OnDelete()
>>>>> method. Is this what you want?
>>>>
>>>> What about adding an accelerator for the DEL key binding, so it
>>>> doesn't matter if the menu is disabled or not?
>>>>
>>>
>>> There's already an accelerator entry for the DEL key. If the menu is
>>> disabled, the method is not fired. So, I only know two solutions: don't
>>> disable the menu item, don't show the Del keybinding in the menu item.
>>
>> Does creating the accelerator table before the menu make any difference?
>>
>
> Nope, doesn't work.

I say we remove the shortcut from the menu option then.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2010-09-06 20:14:50 pgAdmin III commit: Make sure the DEL key is usable in the frmEditGrid
Previous Message Guillaume Lelarge 2010-09-06 16:44:31 Re: Fwd: Pgadmin 1.12 rc1 editing bug