From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pg(at)kuhnsteffen(dot)de, pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: Fwd: Pgadmin 1.12 rc1 editing bug |
Date: | 2010-09-06 20:15:20 |
Message-ID: | 4C854BD8.2040900@lelarge.info |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Le 06/09/2010 21:11, Dave Page a écrit :
> On Mon, Sep 6, 2010 at 5:44 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> Le 06/09/2010 18:37, Dave Page a écrit :
>>> On Mon, Sep 6, 2010 at 5:34 PM, Guillaume Lelarge
>>> <guillaume(at)lelarge(dot)info> wrote:
>>>> Le 06/09/2010 18:13, Dave Page a écrit :
>>>>> On Mon, Sep 6, 2010 at 5:03 PM, Guillaume Lelarge
>>>>> <guillaume(at)lelarge(dot)info> wrote:
>>>>>> It's possible to disable the toolbar button, but we'll need to keep the
>>>>>> menu item enabled so that the DEL key still triggers the OnDelete()
>>>>>> method. Is this what you want?
>>>>>
>>>>> What about adding an accelerator for the DEL key binding, so it
>>>>> doesn't matter if the menu is disabled or not?
>>>>>
>>>>
>>>> There's already an accelerator entry for the DEL key. If the menu is
>>>> disabled, the method is not fired. So, I only know two solutions: don't
>>>> disable the menu item, don't show the Del keybinding in the menu item.
>>>
>>> Does creating the accelerator table before the menu make any difference?
>>>
>>
>> Nope, doesn't work.
>
> I say we remove the shortcut from the menu option then.
>
>
OK, then. Commited on 1.12 and master. Thanks.
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
From | Date | Subject | |
---|---|---|---|
Next Message | pgAdmin Trac | 2010-09-07 00:25:00 | [pgAdmin III] #231: New connection in query tool crashes pgadmin |
Previous Message | Guillaume Lelarge | 2010-09-06 20:14:50 | pgAdmin III commit: Make sure the DEL key is usable in the frmEditGrid |