Re: patch: garbage error strings in libpq

From: jtv(at)xs4all(dot)nl
To: "Neil Conway" <neilc(at)samurai(dot)com>
Cc: jtv(at)xs4all(dot)nl, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: patch: garbage error strings in libpq
Date: 2005-07-06 09:13:14
Message-ID: 8594.202.47.227.25.1120641194.squirrel@202.47.227.25
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway wrote:

> Per C99 6.5.2.2.10, a sequence point occurs between the evaluation of
> the arguments to a function and the call of the function itself.
> Therefore a sequence point occurs before the call to libpq_gettext(). So
> ISTM having libpq_gettext() preserve errno should work.

In C99, at least. But that's not the dialect postgres is written in; even
gcc 4.0 leaves C99 support turned off by default.

Does anyone know what the situation is in C89, or whatever the applicable
standard is?

Jeroen

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2005-07-06 09:39:19 Re: patch: garbage error strings in libpq
Previous Message Neil Conway 2005-07-06 08:24:33 Re: INSERT ... RETURNING