Re: patch: garbage error strings in libpq

From: Neil Conway <neilc(at)samurai(dot)com>
To: jtv(at)xs4all(dot)nl
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: patch: garbage error strings in libpq
Date: 2005-07-06 07:55:39
Message-ID: 42CB8E7B.5080007@samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

jtv(at)xs4all(dot)nl wrote:
> (a) the C standard has added a sequence point between the arguments in a
> function call, which AFAIK wasn't there before, or the sequence point was
> there all along (and the compiler implements it);

Per C99 6.5.2.2.10, a sequence point occurs between the evaluation of
the arguments to a function and the call of the function itself.
Therefore a sequence point occurs before the call to libpq_gettext(). So
ISTM having libpq_gettext() preserve errno should work.

-Neil

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Michael Paesold 2005-07-06 08:23:32 Re: Disable page writes when fsync off, add GUC
Previous Message jtv 2005-07-06 07:06:14 Re: Error handling fix in interfaces/libpq/fe-secure.c