Re: psql \e broken again

From: "Bort, Paul" <pbort(at)tmwsystems(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: psql \e broken again
Date: 2004-11-15 17:07:09
Message-ID: 735D404BD9E7EB44B9CDFC27FC88809B0582D5BD@mail2.tmwsystems.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

From: Peter Eisentraut [mailto:peter_e(at)gmx(dot)net]
>
> Is there a Windows port of the command-line cvs tool? That
> would be a
> good thing to compare with.
>

The one that I see most often ( and use here ) is CVSGUI (
http://www.wincvs.org/ ), which includes a CVS command-line client despite
the name. ( The command-line CVS might be from CVSNT,
http://www.cvsnt.com/cvspro/ ).

So I thought I'd try a few scenarios, since I have it installed:

U:\sandbox\docbook> REM DOUBLE-QUOTES IN COMMAND LINE:
U:\sandbox\docbook> set EDITOR=D:\Program
Files\XEmacs\XEmacs-21.4.13\i586-pc-win32\XEmacs.exe
U:\sandbox\docbook> cvs -d :sspi:pbort(at)cleqa(dot)tmwsystems(dot)com:/repo -e
"%EDITOR%" commit -D xml_reindent.pl
'D:\Program' is not recognized as an internal or external command,
operable program or batch file.
cvs commit: warning: editor session failed

U:\sandbox\docbook> REM DOUBLE-QUOTES IN ENVIRONMENT VARIABLE:
U:\sandbox\docbook> set EDITOR="D:\Program
Files\XEmacs\XEmacs-21.4.13\i586-pc-win32\XEmacs.exe"
U:\sandbox\docbook> cvs -d :sspi:pbort(at)cleqa(dot)tmwsystems(dot)com:/repo -e
%EDITOR% commit -D xml_reindent.pl
'D:\Program' is not recognized as an internal or external command,
operable program or batch file.
cvs commit: warning: editor session failed

U:\sandbox\docbook> REM DOUBLE-QUOTES IN BOTH:
U:\sandbox\docbook> cvs -d :sspi:pbort(at)cleqa(dot)tmwsystems(dot)com:/repo -e
"%EDITOR%" commit -D xml_reindent.pl
Unknown command: `Files\XEmacs\XEmacs-21.4.13\i586-pc-win32\XEmacs.exe'

U:\sandbox\docbook> REM SINGLE-QUOTES IN ENVIRONMENT VARIABLE:
U:\sandbox\docbook> set EDITOR='D:\Program
Files\XEmacs\XEmacs-21.4.13\i586-pc-win32\XEmacs.exe'
U:\sandbox\docbook> cvs -d :sspi:pbort(at)cleqa(dot)tmwsystems(dot)com:/repo -e
%EDITOR% commit -D xml_reindent.pl
Unknown command: `Files\XEmacs\XEmacs-21.4.13\i586-pc-win32\XEmacs.exe''

U:\sandbox\docbook> REM SINGLE-QUOTES IN COMMAND LINE:
U:\sandbox\docbook> set EDITOR=D:\Program
Files\XEmacs\XEmacs-21.4.13\i586-pc-win32\XEmacs.exe
U:\sandbox\docbook> cvs -d :sspi:pbort(at)cleqa(dot)tmwsystems(dot)com:/repo -e
'%EDITOR%' commit -D xml_reindent.pl
Unknown command: `Files\XEmacs\XEmacs-21.4.13\i586-pc-win32\XEmacs.exe''

U:\sandbox\docbook> REM SINGLE-QUOTES IN BOTH:
U:\sandbox\docbook> set EDITOR='D:\Program
Files\XEmacs\XEmacs-21.4.13\i586-pc-win32\XEmacs.exe'
U:\sandbox\docbook> cvs -d :sspi:pbort(at)cleqa(dot)tmwsystems(dot)com:/repo -e
'%EDITOR%' commit -D xml_reindent.pl
Unknown command: `Files\XEmacs\XEmacs-21.4.13\i586-pc-win32\XEmacs.exe'''

U:\sandbox\docbook> REM BACKSLASH-ESCAPE SPACES:
U:\sandbox\docbook> set EDITOR=D:\Program\
Files\XEmacs\XEmacs-21.4.13\i586-pc-win32\XEmacs.exe
U:\sandbox\docbook> cvs -d :sspi:pbort(at)cleqa(dot)tmwsystems(dot)com:/repo -e
%EDITOR% commit -D xml_reindent.pl
Unknown command: `Files\XEmacs\XEmacs-21.4.13\i586-pc-win32\XEmacs.exe'

U:\sandbox\docbook> REM BACKSLASH-ESCAPE SPACES AND DOUBLE-QUOTE ON COMMAND
LINE:
U:\sandbox\docbook> set EDITOR=D:\Program\
Files\XEmacs\XEmacs-21.4.13\i586-pc-win32\XEmacs.exe
U:\sandbox\docbook> cvs -d :sspi:pbort(at)cleqa(dot)tmwsystems(dot)com:/repo -e
"%EDITOR%" commit -D xml_reindent.pl
'D:\Program\' is not recognized as an internal or external command,
operable program or batch file.
cvs commit: warning: editor session failed

U:\sandbox\docbook> REM BACKSLASH-ESCAPE SPACES AND SINGLE-QUOTE ON COMMAND
LINE:
U:\sandbox\docbook> set EDITOR=D:\Program\
Files\XEmacs\XEmacs-21.4.13\i586-pc-win32\XEmacs.exe
U:\sandbox\docbook> cvs -d :sspi:pbort(at)cleqa(dot)tmwsystems(dot)com:/repo -e
"%EDITOR%" commit -D xml_reindent.pl
Unknown command: `Files\XEmacs\XEmacs-21.4.13\i586-pc-win32\XEmacs.exe''

------

The message "is not recognized as an internal or external command..." is
from the operating system, so CVS is at least trying to launch an editor in
those cases.

So to answer your question, at least in part, there is no current good
behavior to emulate. At least on this version of CVS:

Concurrent Versions System (CVSNT) 2.0.51d (client/server)

Copyright (c) 1989-2001 Brian Berliner, david d `zoo' zuhn,
Jeff Polk, and other authors
CVSNT version (Aug 19 2004) Copyright (c) 1999-2004 Tony Hoyle and others
see http://www.cvsnt.org

If you have any other combinations that might make sense, let me know, and
I'll give it a try.

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-11-15 17:19:11 Re: psql \e broken again
Previous Message Tom Lane 2004-11-15 16:54:56 libpq and psql not on same page about SIGPIPE