Re: Kerberos patch in the queue

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <Dah(at)pdc(dot)kth(dot)se>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Kerberos patch in the queue
Date: 2005-04-15 17:41:14
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE6C72E6@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>> I'd like to vote in favor of this patch:
>> http://candle.pha.pa.us/mhonarc/patches2/msg00025.html.
>
>> I know Tom said he didn't really like it, but I'd ask you to
>reconsider
>> that.
>
>The patch is unacceptable as is because (a) it adds a libpq
>configuration parameter that acts differently from all the other ones
>(not supported in connect strings for instance) and (b) it adds no
>documentation for that variable, nor for the server-side variable it
>adds. Doing the libpq parameter in a more thorough fashion is just a
>matter of programming-by-example (grep for CONNECT_TIMEOUT for an
>example) but I for one don't know enough about Kerberos to document
>the thing.

Daniel asked about (a) - I'm not sure if he received an answer, I
couldn't find one at least.
(http://candle.pha.pa.us/mhonarc/patches2/msg00024.html has the question
and some more comments from him). And he offered to write up docs.

Daniel, still up for doing this? If not, I can try to update the patch
to address Toms concerns.

Tom, assuming we fix this, are you fine with the concept? The discussion
back then mentioned the "another way to fail the connection". I think
the gain far overweighs the pain, but it'd be nice to have that
confirmed before more work is committed.

//Magnus

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-04-15 17:53:56 Re: Kerberos patch in the queue
Previous Message Tom Lane 2005-04-15 17:18:12 Re: Kerberos patch in the queue