| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: Make pg_dump suppress COMMENT ON SCHEMA public ? |
| Date: | 2008-01-13 17:13:41 |
| Message-ID: | 5931.1200244421@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Could we dump it when it's non-default only? That way the people that
> *have* set a custom comment on it will still get it restored, just a
> failure in this case. The majority of people who *haven't* set a comment
> will not have the problem at all.
The patch seems ugly enough without wiring in knowledge of what the
standard comment is :-(
We don't dump non-default comments on other system objects either,
so I don't think it's out of line to suppress the one on schema public.
Perhaps at some point we should add something to pg_description to allow
distinguishing user-supplied comments from built-in ones, and then dump
any user-supplied comment on any system object. But not today ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-01-13 17:17:20 | Re: Make pg_dump suppress COMMENT ON SCHEMA public ? |
| Previous Message | Merlin Moncure | 2008-01-13 17:07:50 | Re: Postgresql Materialized views |